diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2022-02-09 21:09:59 +0300 |
|---|---|---|
| committer |   Alex Deucher <alexander.deucher@amd.com> | 2022-02-11 16:10:06 -0500 |
| commit | 5aa71bd773c390891974b1bcbdb3b12aa17c781d (patch) | |
| tree | f7ff1d37e7d806b9a75f822b6be5018be4f12df2 | |
| parent | drm/amdkfd: CRIU fix a NULL vs IS_ERR() check (diff) | |
| download | wireguard-linux-5aa71bd773c390891974b1bcbdb3b12aa17c781d.tar.xz wireguard-linux-5aa71bd773c390891974b1bcbdb3b12aa17c781d.zip | |
drm/amdkfd: CRIU return -EFAULT for copy_to_user() failure
If copy_to_user() fails, it returns the number of bytes remaining to
be copied but we want to return a negative error code (-EFAULT) to the
user.
Fixes: 9d5dabfeff3c ("drm/amdkfd: CRIU Save Shared Virtual Memory ranges")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: David Yat Sin <david.yatsin@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
| -rw-r--r-- | drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c index e13ea9797527..783826640da9 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c @@ -3771,10 +3771,10 @@ int kfd_criu_checkpoint_svm(struct kfd_process *p, goto exit_priv; } - ret = copy_to_user(user_priv_data + *priv_data_offset, - svm_priv, svm_priv_data_size); - if (ret) { + if (copy_to_user(user_priv_data + *priv_data_offset, svm_priv, + svm_priv_data_size)) { pr_err("Failed to copy svm priv to user\n"); + ret = -EFAULT; goto exit_priv; } |