diff options
| author |   Zou Wei <zou_wei@huawei.com> | 2021-05-24 15:20:54 +0800 |
|---|---|---|
| committer |   Maxime Ripard <maxime@cerno.tech> | 2021-05-25 10:32:56 +0200 |
| commit | 5e4322a8b266bc9f5ee7ea4895f661c01dbd7cb3 (patch) | |
| tree | e50be0fd2052802e78e337fd2a9814213c088fb6 | |
| parent | drm/panel: panel-simple: Add missing pm_runtime_dont_use_autosuspend() calls (diff) | |
| download | wireguard-linux-5e4322a8b266bc9f5ee7ea4895f661c01dbd7cb3.tar.xz wireguard-linux-5e4322a8b266bc9f5ee7ea4895f661c01dbd7cb3.zip | |
drm/vc4: hdmi: Fix PM reference leak in vc4_hdmi_encoder_pre_crtc_co()
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/1621840854-105978-1-git-send-email-zou_wei@huawei.com
| -rw-r--r-- | drivers/gpu/drm/vc4/vc4_hdmi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 015d1e9d4ffb..f9de8632a28b 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -901,7 +901,7 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder, unsigned long bvb_rate, pixel_rate, hsm_rate; int ret; - ret = pm_runtime_get_sync(&vc4_hdmi->pdev->dev); + ret = pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev); if (ret < 0) { DRM_ERROR("Failed to retain power domain: %d\n", ret); return; |