diff options
| author |   Nihar Chaithanya <niharchaithanya@gmail.com> | 2024-10-11 17:15:38 +0530 |
|---|---|---|
| committer |   Andrew Morton <akpm@linux-foundation.org> | 2025-01-13 22:40:42 -0800 |
| commit | 5f1c8108e7ad510456733d143b8ffc4e2408b1a1 (patch) | |
| tree | a75af919993c991c8f9c82134b13c10c1fb65bd0 | |
| parent | lazy tlb: fix hotplug exit race with MMU_LAZY_TLB_SHOOTDOWN (diff) | |
| download | wireguard-linux-5f1c8108e7ad510456733d143b8ffc4e2408b1a1.tar.xz wireguard-linux-5f1c8108e7ad510456733d143b8ffc4e2408b1a1.zip | |
mm:kasan: fix sparse warnings: Should it be static?
Yes, when making the global variables kasan_ptr_result and
kasan_int_result as static volatile, the warnings are removed and the
variable and assignments are retained, but when just static is used I
understand that it might be optimized.
Add a fix making the global varaibles - static volatile, removing the
warnings:
mm/kasan/kasan_test.c:36:6: warning: symbol 'kasan_ptr_result' was not declared. Should it be static?
mm/kasan/kasan_test.c:37:5: warning: symbol 'kasan_int_result' was not declared. Should it be static?
Link: https://lkml.kernel.org/r/20241011114537.35664-1-niharchaithanya@gmail.com
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312261010.o0lRiI9b-lkp@intel.com/
Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
| -rw-r--r-- | mm/kasan/kasan_test_c.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/kasan/kasan_test_c.c b/mm/kasan/kasan_test_c.c index 99d4ff0ed57a..59d673400085 100644 --- a/mm/kasan/kasan_test_c.c +++ b/mm/kasan/kasan_test_c.c @@ -47,8 +47,8 @@ static struct { * Some tests use these global variables to store return values from function * calls that could otherwise be eliminated by the compiler as dead code. */ -void *kasan_ptr_result; -int kasan_int_result; +static volatile void *kasan_ptr_result; +static volatile int kasan_int_result; /* Probe for console output: obtains test_status lines of interest. */ static void probe_console(void *ignore, const char *buf, size_t len) |