diff options
| author |   Wolfram Sang <wsa+renesas@sang-engineering.com> | 2024-06-04 23:22:36 +0200 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-07-03 16:40:17 +0200 |
| commit | 71f592d204ba2199a8d4fe174a1024cceb9e9096 (patch) | |
| tree | 45d68dde5ae5951e9ae40c564b015f0381a64d1a | |
| parent | binder_alloc: Replace kcalloc with kvcalloc to mitigate OOM issues (diff) | |
| download | wireguard-linux-71f592d204ba2199a8d4fe174a1024cceb9e9096.tar.xz wireguard-linux-71f592d204ba2199a8d4fe174a1024cceb9e9096.zip | |
misc: apds990x: use 'time_left' variable with wait_event_interruptible_timeout()
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_event_interruptible_timeout() causing patterns like:
timeout = wait_event_interruptible_timeout(...)
if (!timeout) return -ETIMEDOUT;
with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240604212240.4529-2-wsa+renesas@sang-engineering.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/misc/apds990x.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/misc/apds990x.c b/drivers/misc/apds990x.c index 92b92be91d60..5fb29ebbb422 100644 --- a/drivers/misc/apds990x.c +++ b/drivers/misc/apds990x.c @@ -625,15 +625,15 @@ static ssize_t apds990x_lux_show(struct device *dev, struct apds990x_chip *chip = dev_get_drvdata(dev); ssize_t ret; u32 result; - long timeout; + long time_left; if (pm_runtime_suspended(dev)) return -EIO; - timeout = wait_event_interruptible_timeout(chip->wait, - !chip->lux_wait_fresh_res, - msecs_to_jiffies(APDS_TIMEOUT)); - if (!timeout) + time_left = wait_event_interruptible_timeout(chip->wait, + !chip->lux_wait_fresh_res, + msecs_to_jiffies(APDS_TIMEOUT)); + if (!time_left) return -EIO; mutex_lock(&chip->mutex); |