diff options
| author |   Qiu-ji Chen <chenqiuji666@gmail.com> | 2024-11-07 19:35:34 +0800 |
|---|---|---|
| committer |   Johan Hovold <johan@kernel.org> | 2024-11-07 17:21:10 +0100 |
| commit | 8b524944f92ccad925b574f645e9c2709cf60d1e (patch) | |
| tree | 8b4f0e78877f197e396507ecee74f797105bcb7f | |
| parent | USB: serial: pl2303: account for deficits of clones (diff) | |
| download | wireguard-linux-8b524944f92ccad925b574f645e9c2709cf60d1e.tar.xz wireguard-linux-8b524944f92ccad925b574f645e9c2709cf60d1e.zip | |
USB: serial: ftdi_sio: Fix atomicity violation in get_serial_info()
Our static checker found a bug where set_serial_info() uses a mutex, but
get_serial_info() does not. Fortunately, the impact of this is relatively
minor. It doesn't cause a crash or any other serious issues. However, if a
race condition occurs between set_serial_info() and get_serial_info(),
there is a chance that the data returned by get_serial_info() will be
inconsistent.
Fixes: 3ae36bed3a93 ("fdti_sio: switch to ->[sg]et_serial()")
Signed-off-by: Qiu-ji Chen <chenqiuji666@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/ftdi_sio.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c index c6f17d732b95..e07c5e3eb18c 100644 --- a/drivers/usb/serial/ftdi_sio.c +++ b/drivers/usb/serial/ftdi_sio.c @@ -1443,9 +1443,11 @@ static void get_serial_info(struct tty_struct *tty, struct serial_struct *ss) struct usb_serial_port *port = tty->driver_data; struct ftdi_private *priv = usb_get_serial_port_data(port); + mutex_lock(&priv->cfg_lock); ss->flags = priv->flags; ss->baud_base = priv->baud_base; ss->custom_divisor = priv->custom_divisor; + mutex_unlock(&priv->cfg_lock); } static int set_serial_info(struct tty_struct *tty, struct serial_struct *ss) |