diff options
| author |   Ma Ke <make_ruc2021@163.com> | 2023-10-07 11:31:05 +0800 |
|---|---|---|
| committer |   Neil Armstrong <neil.armstrong@linaro.org> | 2023-10-10 10:33:30 +0200 |
| commit | 924e5814d1f84e6fa5cb19c6eceb69f066225229 (patch) | |
| tree | 5bbda8c47a47cd647b41648a397225400fc6f1dd | |
| parent | drm/rockchip: dsi: Use devm_platform_get_and_ioremap_resource() (diff) | |
| download | wireguard-linux-924e5814d1f84e6fa5cb19c6eceb69f066225229.tar.xz wireguard-linux-924e5814d1f84e6fa5cb19c6eceb69f066225229.zip | |
drm/panel: fix a possible null pointer dereference
In versatile_panel_get_modes(), the return value of drm_mode_duplicate()
is assigned to mode, which will lead to a NULL pointer dereference
on failure of drm_mode_duplicate(). Add a check to avoid npd.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20231007033105.3997998-1-make_ruc2021@163.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231007033105.3997998-1-make_ruc2021@163.com
| -rw-r--r-- | drivers/gpu/drm/panel/panel-arm-versatile.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/panel/panel-arm-versatile.c b/drivers/gpu/drm/panel/panel-arm-versatile.c index abb0788843c6..503ecea72c5e 100644 --- a/drivers/gpu/drm/panel/panel-arm-versatile.c +++ b/drivers/gpu/drm/panel/panel-arm-versatile.c @@ -267,6 +267,8 @@ static int versatile_panel_get_modes(struct drm_panel *panel, connector->display_info.bus_flags = vpanel->panel_type->bus_flags; mode = drm_mode_duplicate(connector->dev, &vpanel->panel_type->mode); + if (!mode) + return -ENOMEM; drm_mode_set_name(mode); mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; |