diff options
| author |   Stefan Eichenberger <stefan.eichenberger@toradex.com> | 2025-03-05 15:43:15 +0100 |
|---|---|---|
| committer |   Vinod Koul <vkoul@kernel.org> | 2025-03-11 01:12:37 +0530 |
| commit | 97e8a2ff28a3dc36ca3cdc94f37359852d7e1c8b (patch) | |
| tree | 42af6bd55cb7f7d5e4f3e9a204f1b4ecf73413ad | |
| parent | phy: core: Remove unused phy_pm_runtime_(allow|forbid) (diff) | |
| download | wireguard-linux-97e8a2ff28a3dc36ca3cdc94f37359852d7e1c8b.tar.xz wireguard-linux-97e8a2ff28a3dc36ca3cdc94f37359852d7e1c8b.zip | |
phy: freescale: imx8m-pcie: cleanup reset logic
Remove the switch statement and base perst release on whether it is
found in the device tree. The probe function fails without the reset
property, making it mandatory. Therefore, always release reset
independent of the variant.
This does not change the behavior of the driver but reduces driver
complexity and allows for easier future modifications.
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250305144355.20364-2-eichest@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/phy/freescale/phy-fsl-imx8m-pcie.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c index e98361dcdead..5b505e34ca36 100644 --- a/drivers/phy/freescale/phy-fsl-imx8m-pcie.c +++ b/drivers/phy/freescale/phy-fsl-imx8m-pcie.c @@ -141,15 +141,9 @@ static int imx8_pcie_phy_power_on(struct phy *phy) IMX8MM_GPR_PCIE_REF_CLK_PLL); usleep_range(100, 200); - switch (imx8_phy->drvdata->variant) { - case IMX8MP: - reset_control_deassert(imx8_phy->perst); - fallthrough; - case IMX8MM: - reset_control_deassert(imx8_phy->reset); - usleep_range(200, 500); - break; - } + reset_control_deassert(imx8_phy->perst); + reset_control_deassert(imx8_phy->reset); + usleep_range(200, 500); /* Do the PHY common block reset */ regmap_update_bits(imx8_phy->iomuxc_gpr, IOMUXC_GPR14, |