diff options
| author |   Somnath Kotur <somnath.kotur@broadcom.com> | 2025-04-28 15:58:58 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2025-04-30 13:03:21 +0100 |
| commit | a63db07e4ecd45b027718168faf7d798bb47bf58 (patch) | |
| tree | 439530e01beccc5c917743a82c5f92e37d6326e6 | |
| parent | bnxt_en: Fix ethtool selftest output in one of the failure cases (diff) | |
| download | wireguard-linux-a63db07e4ecd45b027718168faf7d798bb47bf58.tar.xz wireguard-linux-a63db07e4ecd45b027718168faf7d798bb47bf58.zip | |
bnxt_en: Add missing skb_mark_for_recycle() in bnxt_rx_vlan()
If bnxt_rx_vlan() fails because the VLAN protocol ID is invalid,
the SKB is freed but we're missing the call to recycle it. This
may cause the warning:
"page_pool_release_retry() stalled pool shutdown"
Add the missing skb_mark_for_recycle() in bnxt_rx_vlan().
Fixes: 86b05508f775 ("bnxt_en: Use the unified RX page pool buffers for XDP and non-XDP")
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index c4bccc683597..cfc9ccab39bf 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -2015,6 +2015,7 @@ static struct sk_buff *bnxt_rx_vlan(struct sk_buff *skb, u8 cmp_type, } return skb; vlan_err: + skb_mark_for_recycle(skb); dev_kfree_skb(skb); return NULL; } |