diff options
| author |   Josh Poimboeuf <jpoimboe@kernel.org> | 2025-03-24 14:56:03 -0700 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2025-03-25 09:20:28 +0100 |
| commit | a8d39a62c6f5ad76b8a1ebfbf10dd9fe8ca2bbcc (patch) | |
| tree | aa168fe85fa6b8554b6ef6244928c98bc0a1793c | |
| parent | objtool: Remove --no-unreachable for noinstr-only vmlinux.o runs (diff) | |
| download | wireguard-linux-a8d39a62c6f5ad76b8a1ebfbf10dd9fe8ca2bbcc.tar.xz wireguard-linux-a8d39a62c6f5ad76b8a1ebfbf10dd9fe8ca2bbcc.zip | |
objtool: Remove redundant opts.noinstr dependency
The --noinstr dependecy on --link is already enforced in the cmdline arg
parsing code. Remove the redundant check.
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: https://lore.kernel.org/r/0ead7ffa0f5be2e81aebbcc585e07b2c98702b44.1742852847.git.jpoimboe@kernel.org
| -rw-r--r-- | tools/objtool/check.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/tools/objtool/check.c b/tools/objtool/check.c index ac21f2846ebc..0caabf0e8faf 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -340,12 +340,7 @@ static void init_insn_state(struct objtool_file *file, struct insn_state *state, memset(state, 0, sizeof(*state)); init_cfi_state(&state->cfi); - /* - * We need the full vmlinux for noinstr validation, otherwise we can - * not correctly determine insn_call_dest(insn)->sec (external symbols - * do not have a section). - */ - if (opts.link && opts.noinstr && sec) + if (opts.noinstr && sec) state->noinstr = sec->noinstr; } |