diff options
| author |   Filipe Manana <fdmanana@suse.com> | 2025-02-18 16:00:14 +0000 |
|---|---|---|
| committer |   David Sterba <dsterba@suse.com> | 2025-03-18 20:35:46 +0100 |
| commit | ab12858161b05ca9c47f28f2ce682f82786df919 (patch) | |
| tree | 9c80732ba9e31bf931cb216403dc73469a8a72ac | |
| parent | btrfs: send: remove unnecessary return variable from process_new_xattr() (diff) | |
| download | wireguard-linux-ab12858161b05ca9c47f28f2ce682f82786df919.tar.xz wireguard-linux-ab12858161b05ca9c47f28f2ce682f82786df919.zip | |
btrfs: send: simplify return logic from process_changed_xattr()
There is no need to have an 'out' label and jump into it since there are
no resource cleanups to perform (release locks, free memory, etc), so
make this simpler by removing the label and goto and instead return
directly.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/send.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index e29b5a5ccdd6..0cbc8b5b6fab 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -5067,17 +5067,15 @@ static int __process_changed_deleted_xattr(int num, struct btrfs_key *di_key, static int process_changed_xattr(struct send_ctx *sctx) { - int ret = 0; + int ret; ret = iterate_dir_item(sctx->send_root, sctx->left_path, __process_changed_new_xattr, sctx); if (ret < 0) - goto out; - ret = iterate_dir_item(sctx->parent_root, sctx->right_path, - __process_changed_deleted_xattr, sctx); + return ret; -out: - return ret; + return iterate_dir_item(sctx->parent_root, sctx->right_path, + __process_changed_deleted_xattr, sctx); } static int process_all_new_xattrs(struct send_ctx *sctx) |