diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2021-10-04 13:38:06 +0300 |
|---|---|---|
| committer |   Rob Clark <robdclark@chromium.org> | 2021-10-15 13:26:34 -0700 |
| commit | b6816441a14bbe356ba8590de79cfea2de6a085c (patch) | |
| tree | 565ecd3e2650a87eba381c3f965500b3071c6f6e | |
| parent | drm/msm: Fix potential Oops in a6xx_gmu_rpmh_init() (diff) | |
| download | wireguard-linux-b6816441a14bbe356ba8590de79cfea2de6a085c.tar.xz wireguard-linux-b6816441a14bbe356ba8590de79cfea2de6a085c.zip | |
drm/msm: potential error pointer dereference in init()
The msm_iommu_new() returns error pointers on failure so check for that
to avoid an Oops.
Fixes: ccac7ce373c1 ("drm/msm: Refactor address space initialization")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20211004103806.GD25015@kili
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Rob Clark <robdclark@chromium.org>
| -rw-r--r-- | drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index ae48f41821cf..ad247c06e198 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -908,6 +908,10 @@ static int _dpu_kms_mmu_init(struct dpu_kms *dpu_kms) return 0; mmu = msm_iommu_new(dpu_kms->dev->dev, domain); + if (IS_ERR(mmu)) { + iommu_domain_free(domain); + return PTR_ERR(mmu); + } aspace = msm_gem_address_space_create(mmu, "dpu1", 0x1000, 0x100000000 - 0x1000); |