diff options
| author |   Advait Dhamorikar <advaitdhamorikar@gmail.com> | 2024-12-19 10:09:39 +0530 |
|---|---|---|
| committer |   Leon Romanovsky <leon@kernel.org> | 2024-12-19 07:16:31 -0500 |
| commit | c57c76498a895a705b624ed65dfe5a3037b78d83 (patch) | |
| tree | bf46ebec416b0d7d34f8505bed5d232fc7c8e3e7 | |
| parent | RDMA/srp: Fix error handling in srp_add_port (diff) | |
| download | wireguard-linux-c57c76498a895a705b624ed65dfe5a3037b78d83.tar.xz wireguard-linux-c57c76498a895a705b624ed65dfe5a3037b78d83.zip | |
RDMA/erdma: Fix opcode conditional check
Fix conditional if else check by checking with wr->opcode.
The indicated dead code may have performed some action; that
action will never occur as op is pre-assigned a different value.
Fixes: 999a0a2e9b87 ("RDMA/erdma: Support UD QPs and UD WRs")
Signed-off-by: Advait Dhamorikar <advaitdhamorikar@gmail.com>
Link: https://patch.msgid.link/20241219043939.10344-1-advaitdhamorikar@gmail.com
Reviewed-by: Cheng Xu <chengyou@linux.alibaba.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
| -rw-r--r-- | drivers/infiniband/hw/erdma/erdma_qp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/infiniband/hw/erdma/erdma_qp.c b/drivers/infiniband/hw/erdma/erdma_qp.c index 4dfb4272ad86..5c266918fb36 100644 --- a/drivers/infiniband/hw/erdma/erdma_qp.c +++ b/drivers/infiniband/hw/erdma/erdma_qp.c @@ -406,7 +406,7 @@ static void init_send_sqe_rc(struct erdma_qp *qp, struct erdma_send_sqe_rc *sqe, if (wr->opcode == IB_WR_SEND_WITH_IMM) { op = ERDMA_OP_SEND_WITH_IMM; sqe->imm_data = wr->ex.imm_data; - } else if (op == IB_WR_SEND_WITH_INV) { + } else if (wr->opcode == IB_WR_SEND_WITH_INV) { op = ERDMA_OP_SEND_WITH_INV; sqe->invalid_stag = cpu_to_le32(wr->ex.invalidate_rkey); } |