diff options
| author |   Breno Leitao <leitao@debian.org> | 2024-11-18 03:15:17 -0800 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2024-11-18 19:01:36 -0800 |
| commit | c69c5e10adb903ae2438d4f9c16eccf43d1fcbc1 (patch) | |
| tree | 140b123af80f627f6414393f259937b9f85ea135 | |
| parent | MAINTAINERS: exclude can core, drivers and DT bindings from netdev ML (diff) | |
| download | wireguard-linux-c69c5e10adb903ae2438d4f9c16eccf43d1fcbc1.tar.xz wireguard-linux-c69c5e10adb903ae2438d4f9c16eccf43d1fcbc1.zip | |
netpoll: Use rcu_access_pointer() in __netpoll_setup
The ndev->npinfo pointer in __netpoll_setup() is RCU-protected but is being
accessed directly for a NULL check. While no RCU read lock is held in this
context, we should still use proper RCU primitives for consistency and
correctness.
Replace the direct NULL check with rcu_access_pointer(), which is the
appropriate primitive when only checking for NULL without dereferencing
the pointer. This function provides the necessary ordering guarantees
without requiring RCU read-side protection.
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20241118-netpoll_rcu-v1-1-a1888dcb4a02@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/core/netpoll.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index aa49b92e9194..45fb60bc4803 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -626,7 +626,7 @@ int __netpoll_setup(struct netpoll *np, struct net_device *ndev) goto out; } - if (!ndev->npinfo) { + if (!rcu_access_pointer(ndev->npinfo)) { npinfo = kmalloc(sizeof(*npinfo), GFP_KERNEL); if (!npinfo) { err = -ENOMEM; |