aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>2025-02-17 11:39:21 +0100
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>2025-02-18 11:26:33 +0100
commitdea69f2d1cc8d9ecdc72ba350d10a1e71940ef18 (patch)
tree51572f353e802092035bc79596f7654bcd9b1707
parentgpio: loongson-64bit: Remove unneeded ngpio assignment (diff)
downloadwireguard-linux-dea69f2d1cc8d9ecdc72ba350d10a1e71940ef18.tar.xz
wireguard-linux-dea69f2d1cc8d9ecdc72ba350d10a1e71940ef18.zip
gpiolib: move all includes to the top of gpio/consumer.h
We have several conditional includes depending on !CONFIG_GPIOLIB. This is supposed to reduce compilation time with CONFIG_GPIOLIB=y but in practice there's no difference on modern machines. It makes adding new stubs that depend on more than just GPIOLIB harder so move them all to the top, unduplicate them and replace asm/ with preferred linux/ alternatives. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Link: https://lore.kernel.org/r/20250217103922.151047-1-brgl@bgdev.pl Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
-rw-r--r--include/linux/gpio/consumer.h12
1 files changed, 3 insertions, 9 deletions
diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
index 5cbd4afd7862..0dc49b5fca5c 100644
--- a/include/linux/gpio/consumer.h
+++ b/include/linux/gpio/consumer.h
@@ -3,7 +3,10 @@
#define __LINUX_GPIO_CONSUMER_H
#include <linux/bits.h>
+#include <linux/bug.h>
#include <linux/err.h>
+#include <linux/errno.h>
+#include <linux/kernel.h>
#include <linux/types.h>
struct acpi_device;
@@ -184,11 +187,6 @@ struct gpio_desc *devm_fwnode_gpiod_get_index(struct device *dev,
#else /* CONFIG_GPIOLIB */
-#include <linux/err.h>
-#include <linux/kernel.h>
-
-#include <asm/bug.h>
-
static inline int gpiod_count(struct device *dev, const char *con_id)
{
return 0;
@@ -609,8 +607,6 @@ int devm_acpi_dev_add_driver_gpios(struct device *dev,
#else /* CONFIG_GPIOLIB && CONFIG_ACPI */
-#include <linux/err.h>
-
static inline int acpi_dev_add_driver_gpios(struct acpi_device *adev,
const struct acpi_gpio_mapping *gpios)
{
@@ -636,8 +632,6 @@ void gpiod_unexport(struct gpio_desc *desc);
#else /* CONFIG_GPIOLIB && CONFIG_GPIO_SYSFS */
-#include <asm/errno.h>
-
static inline int gpiod_export(struct gpio_desc *desc,
bool direction_may_change)
{