diff options
| author |   Javier Carrasco <javier.carrasco.cruz@gmail.com> | 2024-06-19 21:42:45 +0200 |
|---|---|---|
| committer |   Johan Hovold <johan@kernel.org> | 2024-07-05 14:01:43 +0200 |
| commit | df8c0b8a03e871431587a13a6765cb4c601e1573 (patch) | |
| tree | ce46c80dc8dca02d2394bdb6bbbb2dd177565250 | |
| parent | USB: serial: garmin_gps: annotate struct garmin_packet with __counted_by (diff) | |
| download | wireguard-linux-df8c0b8a03e871431587a13a6765cb4c601e1573.tar.xz wireguard-linux-df8c0b8a03e871431587a13a6765cb4c601e1573.zip | |
USB: serial: garmin_gps: use struct_size() to allocate pkt
Use the struct_size macro to calculate the size of the pkt, which
includes a trailing flexible array.
Suggested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <kees@kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/garmin_gps.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c index 57df6ad183ff..6d6ec7eed87c 100644 --- a/drivers/usb/serial/garmin_gps.c +++ b/drivers/usb/serial/garmin_gps.c @@ -267,8 +267,7 @@ static int pkt_add(struct garmin_data *garmin_data_p, /* process only packets containing data ... */ if (data_length) { - pkt = kmalloc(sizeof(struct garmin_packet)+data_length, - GFP_ATOMIC); + pkt = kmalloc(struct_size(pkt, data, data_length), GFP_ATOMIC); if (!pkt) return 0; |