diff options
| author |   Beleswar Padhi <b-padhi@ti.com> | 2024-12-19 16:35:42 +0530 |
|---|---|---|
| committer |   Mathieu Poirier <mathieu.poirier@linaro.org> | 2025-01-06 09:14:11 -0700 |
| commit | f2e3d0d70986b1f135963dc28462fce4e65c0fc4 (patch) | |
| tree | 7a1c1b7d5525192f8d776a1c1f499dba625a35a3 | |
| parent | remoteproc: k3-r5: Add devm action to release reserved memory (diff) | |
| download | wireguard-linux-f2e3d0d70986b1f135963dc28462fce4e65c0fc4.tar.xz wireguard-linux-f2e3d0d70986b1f135963dc28462fce4e65c0fc4.zip | |
remoteproc: k3-r5: Use devm_kcalloc() helper
Use a device lifecycle managed action to free memory. This helps prevent
mistakes like freeing out of order in cleanup functions and forgetting
to free on error paths.
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
Reviewed-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20241219110545.1898883-3-b-padhi@ti.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
| -rw-r--r-- | drivers/remoteproc/ti_k3_r5_remoteproc.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c index d51f88a5abc1..0753a5c35c7e 100644 --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c @@ -997,7 +997,7 @@ static int k3_r5_reserved_mem_init(struct k3_r5_rproc *kproc) return ret; num_rmems--; - kproc->rmem = kcalloc(num_rmems, sizeof(*kproc->rmem), GFP_KERNEL); + kproc->rmem = devm_kcalloc(dev, num_rmems, sizeof(*kproc->rmem), GFP_KERNEL); if (!kproc->rmem) return -ENOMEM; @@ -1049,7 +1049,6 @@ static int k3_r5_reserved_mem_init(struct k3_r5_rproc *kproc) unmap_rmem: for (i--; i >= 0; i--) iounmap(kproc->rmem[i].cpu_addr); - kfree(kproc->rmem); return ret; } @@ -1059,7 +1058,6 @@ static void k3_r5_reserved_mem_exit(struct k3_r5_rproc *kproc) for (i = 0; i < kproc->num_rmems; i++) iounmap(kproc->rmem[i].cpu_addr); - kfree(kproc->rmem); } /* |