diff options
| author |   Andrzej Pietrasiewicz <andrzej.p@samsung.com> | 2015-03-13 11:08:08 +0100 |
|---|---|---|
| committer |   Felipe Balbi <balbi@ti.com> | 2015-03-13 10:41:05 -0500 |
| commit | fbdecad99c3f37346ed868fec0c3a9c2809f78e9 (patch) | |
| tree | 343c7f3ec797185c7a734f0968e65746db18b270 | |
| parent | usb: gadget: printer: use after free in gprinter_alloc_inst() (diff) | |
| download | wireguard-linux-fbdecad99c3f37346ed868fec0c3a9c2809f78e9.tar.xz wireguard-linux-fbdecad99c3f37346ed868fec0c3a9c2809f78e9.zip | |
usb: gadget: f_printer: use non-zero flag for bitwise and
USB_DIR_OUT happens to be zero, so the result of bitwise and is always 0.
Consequently, break will never happen in the SOFT_RESET case.
This patch uses a compatible condition with a non-zero USB_DIR_IN,
which might or might not evaluate to zero.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
| -rw-r--r-- | drivers/usb/gadget/function/f_printer.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/function/f_printer.c b/drivers/usb/gadget/function/f_printer.c index 48882ecf1610..44173df27273 100644 --- a/drivers/usb/gadget/function/f_printer.c +++ b/drivers/usb/gadget/function/f_printer.c @@ -918,7 +918,7 @@ static bool gprinter_req_match(struct usb_function *f, return false; case SOFT_RESET: if (!w_value && !w_length && - (USB_DIR_OUT & ctrl->bRequestType)) + !(USB_DIR_IN & ctrl->bRequestType)) break; /* fall through */ default: |