aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorJulia Lawall <Julia.Lawall@inria.fr>2020-04-30 21:51:32 +0200
committerDavid S. Miller <davem@davemloft.net>2020-04-30 17:48:26 -0700
commit865308373ed49c9fb05720d14cbf1315349b32a9 (patch)
treea68b66d18f101e2d55524d5cdb0d3abcf6c2ade0
parentnet: bridge: vlan: Add a schedule point during VLAN processing (diff)
downloadwireguard-linux-865308373ed49c9fb05720d14cbf1315349b32a9.tar.xz
wireguard-linux-865308373ed49c9fb05720d14cbf1315349b32a9.zip
dp83640: reverse arguments to list_add_tail
In this code, it appears that phyter_clocks is a list head, based on the previous list_for_each, and that clock->list is intended to be a list element, given that it has just been initialized in dp83640_clock_init. Accordingly, switch the arguments to list_add_tail, which takes the list head as the second argument. Fixes: cb646e2b02b27 ("ptp: Added a clock driver for the National Semiconductor PHYTER.") Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/phy/dp83640.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/phy/dp83640.c b/drivers/net/phy/dp83640.c
index 415c27310982..ecbd5e0d685c 100644
--- a/drivers/net/phy/dp83640.c
+++ b/drivers/net/phy/dp83640.c
@@ -1120,7 +1120,7 @@ static struct dp83640_clock *dp83640_clock_get_bus(struct mii_bus *bus)
goto out;
}
dp83640_clock_init(clock, bus);
- list_add_tail(&phyter_clocks, &clock->list);
+ list_add_tail(&clock->list, &phyter_clocks);
out:
mutex_unlock(&phyter_clocks_lock);