diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2020-04-26 22:59:21 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-04-30 20:23:49 -0700 |
| commit | ee8d2267f0e39a1bfd95532da3a6405004114b27 (patch) | |
| tree | 726a218a5c59fb3b2109012c4bfe193576c4f770 | |
| parent | net: macsec: preserve ingress frame ordering (diff) | |
| download | wireguard-linux-ee8d2267f0e39a1bfd95532da3a6405004114b27.tar.xz wireguard-linux-ee8d2267f0e39a1bfd95532da3a6405004114b27.zip | |
net: moxa: Fix a potential double 'free_irq()'
Should an irq requested with 'devm_request_irq' be released explicitly,
it should be done by 'devm_free_irq()', not 'free_irq()'.
Fixes: 6c821bd9edc9 ("net: Add MOXA ART SoCs ethernet driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/moxa/moxart_ether.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/moxa/moxart_ether.c b/drivers/net/ethernet/moxa/moxart_ether.c index e1651756bf9d..f70bb81e1ed6 100644 --- a/drivers/net/ethernet/moxa/moxart_ether.c +++ b/drivers/net/ethernet/moxa/moxart_ether.c @@ -564,7 +564,7 @@ static int moxart_remove(struct platform_device *pdev) struct net_device *ndev = platform_get_drvdata(pdev); unregister_netdev(ndev); - free_irq(ndev->irq, ndev); + devm_free_irq(&pdev->dev, ndev->irq, ndev); moxart_mac_free_memory(ndev); free_netdev(ndev); |