diff options
| author |   Rosen Penev <rosenp@gmail.com> | 2024-10-30 13:37:20 -0700 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2024-11-03 14:37:42 -0800 |
| commit | 01902fe2bdd75d028dd004fa2dfc95bc65f055bc (patch) | |
| tree | 4df10a1c7aaed21fad5c52c61f86f23759b7460b | |
| parent | net: ibm: emac: rgmii: use devm for kzalloc (diff) | |
| download | wireguard-linux-01902fe2bdd75d028dd004fa2dfc95bc65f055bc.tar.xz wireguard-linux-01902fe2bdd75d028dd004fa2dfc95bc65f055bc.zip | |
net: ibm: emac: rgmii: use devm for mutex_init
It seems that since inception, this driver never called mutex_destroy in
_remove. Use devm to handle this automatically.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Link: https://patch.msgid.link/20241030203727.6039-6-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/ethernet/ibm/emac/rgmii.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/drivers/net/ethernet/ibm/emac/rgmii.c b/drivers/net/ethernet/ibm/emac/rgmii.c index 7bafe2edfc50..9063f0a17e25 100644 --- a/drivers/net/ethernet/ibm/emac/rgmii.c +++ b/drivers/net/ethernet/ibm/emac/rgmii.c @@ -219,13 +219,17 @@ static int rgmii_probe(struct platform_device *ofdev) struct device_node *np = ofdev->dev.of_node; struct rgmii_instance *dev; struct resource regs; + int err; dev = devm_kzalloc(&ofdev->dev, sizeof(struct rgmii_instance), GFP_KERNEL); if (!dev) return -ENOMEM; - mutex_init(&dev->lock); + err = devm_mutex_init(&ofdev->dev, &dev->lock); + if (err) + return err; + dev->ofdev = ofdev; if (of_address_to_resource(np, 0, ®s)) { |