aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorTianci Yin <tianci.yin@amd.com>2023-02-06 15:58:46 +0800
committerAlex Deucher <alexander.deucher@amd.com>2023-04-18 16:28:54 -0400
commit0c316556d124916e1dc2be171b3414b764972802 (patch)
tree8cab47c5036be872a1fc2f3d715d5ee7c79d1ee8
parentdrm/amd/display: Write TEST_EDID_CHECKSUM_WRITE for EDID tests (diff)
downloadwireguard-linux-0c316556d124916e1dc2be171b3414b764972802.tar.xz
wireguard-linux-0c316556d124916e1dc2be171b3414b764972802.zip
drm/amd/display: Disable migration to ensure consistency of per-CPU variable
[why] Since the variable fpu_recursion_depth is per-CPU type, it has one copy on each CPU, thread migration causes data consistency issue, then the call trace shows up. And preemption disabling can't prevent migration. [how] Disable migration to ensure consistency of fpu_recursion_depth. Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com> Signed-off-by: Tianci Yin <tianci.yin@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c b/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
index 1743ca0a3641..c42aa947c969 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
@@ -89,6 +89,7 @@ void dc_fpu_begin(const char *function_name, const int line)
if (*pcpu == 1) {
#if defined(CONFIG_X86)
+ migrate_disable();
kernel_fpu_begin();
#elif defined(CONFIG_PPC64)
if (cpu_has_feature(CPU_FTR_VSX_COMP)) {
@@ -129,6 +130,7 @@ void dc_fpu_end(const char *function_name, const int line)
if (*pcpu <= 0) {
#if defined(CONFIG_X86)
kernel_fpu_end();
+ migrate_enable();
#elif defined(CONFIG_PPC64)
if (cpu_has_feature(CPU_FTR_VSX_COMP)) {
disable_kernel_vsx();