aboutsummaryrefslogtreecommitdiffstatshomepage
diff options
context:
space:
mode:
authorJason A. Donenfeld <Jason@zx2c4.com>2020-03-18 18:30:46 -0600
committerDavid S. Miller <davem@davemloft.net>2020-03-18 18:51:43 -0700
commit2b8765c52db24c0fbcc81bac9b5e8390f2c7d3c8 (patch)
tree9d14717299985224686df0e2af80ee33c77b4597
parentwireguard: queueing: account for skb->protocol==0 (diff)
downloadwireguard-linux-2b8765c52db24c0fbcc81bac9b5e8390f2c7d3c8.tar.xz
wireguard-linux-2b8765c52db24c0fbcc81bac9b5e8390f2c7d3c8.zip
wireguard: receive: remove dead code from default packet type case
The situation in which we wind up hitting the default case here indicates a major bug in earlier parsing code. It is not a usual thing that should ever happen, which means a "friendly" message for it doesn't make sense. Rather, replace this with a WARN_ON, just like we do earlier in the file for a similar situation, so that somebody sends us a bug report and we can fix it. Reported-by: Fabian Freyer <fabianfreyer@radicallyopensecurity.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/wireguard/receive.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/wireguard/receive.c b/drivers/net/wireguard/receive.c
index 243ed7172dd2..da3b782ab7d3 100644
--- a/drivers/net/wireguard/receive.c
+++ b/drivers/net/wireguard/receive.c
@@ -587,8 +587,7 @@ void wg_packet_receive(struct wg_device *wg, struct sk_buff *skb)
wg_packet_consume_data(wg, skb);
break;
default:
- net_dbg_skb_ratelimited("%s: Invalid packet from %pISpfsc\n",
- wg->dev->name, skb);
+ WARN(1, "Non-exhaustive parsing of packet header lead to unknown packet type!\n");
goto err;
}
return;