diff options
| author |   Yang Yingliang <yangyingliang@huawei.com> | 2022-12-08 22:21:44 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-12-12 09:56:17 +0000 |
| commit | d1678bf45f21fa5ae4a456f821858679556ea5f8 (patch) | |
| tree | e6e4249b36d3893d02b22f8c011dc3b38df9dc21 | |
| parent | net: apple: bmac: don't call dev_kfree_skb() under spin_lock_irqsave() (diff) | |
| download | wireguard-linux-d1678bf45f21fa5ae4a456f821858679556ea5f8.tar.xz wireguard-linux-d1678bf45f21fa5ae4a456f821858679556ea5f8.zip | |
net: emaclite: don't call dev_kfree_skb() under spin_lock_irqsave()
It is not allowed to call kfree_skb() or consume_skb() from hardware
interrupt context or with hardware interrupts being disabled.
It should use dev_kfree_skb_irq() or dev_consume_skb_irq() instead.
The difference between them is free reason, dev_kfree_skb_irq() means
the SKB is dropped in error and dev_consume_skb_irq() means the SKB
is consumed in normal.
In this case, dev_kfree_skb() is called in xemaclite_tx_timeout() to
drop the SKB, when tx timeout, so replace it with dev_kfree_skb_irq().
Fixes: bb81b2ddfa19 ("net: add Xilinx emac lite device driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/xilinx/xilinx_emaclite.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index a3967f8de417..ad2c30d9a482 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -536,7 +536,7 @@ static void xemaclite_tx_timeout(struct net_device *dev, unsigned int txqueue) xemaclite_enable_interrupts(lp); if (lp->deferred_skb) { - dev_kfree_skb(lp->deferred_skb); + dev_kfree_skb_irq(lp->deferred_skb); lp->deferred_skb = NULL; dev->stats.tx_errors++; } |