diff options
| author |   Alexander Lobakin <alobakin@marvell.com> | 2020-06-23 16:51:35 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2020-06-23 15:01:16 -0700 |
| commit | ec6c80590bde6b5dfa4970fffa3572f1acd313ca (patch) | |
| tree | 6687b950c26638923241a50391520166703e2d33 | |
| parent | net: qede: fix PTP initialization on recovery (diff) | |
| download | wireguard-linux-ec6c80590bde6b5dfa4970fffa3572f1acd313ca.tar.xz wireguard-linux-ec6c80590bde6b5dfa4970fffa3572f1acd313ca.zip | |
net: qede: fix use-after-free on recovery and AER handling
Set edev->cdev pointer to NULL after calling remove() callback to avoid
using of already freed object.
Fixes: ccc67ef50b90 ("qede: Error recovery process")
Signed-off-by: Alexander Lobakin <alobakin@marvell.com>
Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/qlogic/qede/qede_main.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qede/qede_main.c b/drivers/net/ethernet/qlogic/qede/qede_main.c index f6ff31e73ebe..29e285430f99 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_main.c +++ b/drivers/net/ethernet/qlogic/qede/qede_main.c @@ -1318,6 +1318,7 @@ static void __qede_remove(struct pci_dev *pdev, enum qede_remove_mode mode) if (system_state == SYSTEM_POWER_OFF) return; qed_ops->common->remove(cdev); + edev->cdev = NULL; /* Since this can happen out-of-sync with other flows, * don't release the netdevice until after slowpath stop |