diff options
| author |   Thomas Zimmermann <tzimmermann@suse.de> | 2025-04-10 10:37:24 +0200 |
|---|---|---|
| committer | Thomas Zimmermann <tzimmermann@suse.de> | 2025-04-14 10:16:13 +0200 |
| commit | 6046b49bafff47726a377ef05dc55ef7dec01cbd (patch) | |
| tree | 07e8e6677459919d93e19e6edaedc63a0c2f281b /drivers/gpu/drm/sysfb/vesadrm.c | |
| parent | drm/sysfb: Split source file (diff) | |
| download | wireguard-linux-6046b49bafff47726a377ef05dc55ef7dec01cbd.tar.xz wireguard-linux-6046b49bafff47726a377ef05dc55ef7dec01cbd.zip | |
drm/sysfb: Share helpers for integer validation
Provide sysfb helpers for validating framebuffer integer values
against limits. Update drivers. If a driver did not specify a limit
for a certain value, use INT_MAX.
v2:
- declare module information near EOF (Javier)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://lore.kernel.org/r/20250410083834.10810-3-tzimmermann@suse.de
Diffstat (limited to '')
| -rw-r--r-- | drivers/gpu/drm/sysfb/vesadrm.c | 29 |
1 files changed, 4 insertions, 25 deletions
diff --git a/drivers/gpu/drm/sysfb/vesadrm.c b/drivers/gpu/drm/sysfb/vesadrm.c index 9cc50e3072ea..d87ff77be20d 100644 --- a/drivers/gpu/drm/sysfb/vesadrm.c +++ b/drivers/gpu/drm/sysfb/vesadrm.c @@ -36,28 +36,6 @@ #define VESADRM_GAMMA_LUT_SIZE 256 -static int vesadrm_get_validated_int(struct drm_device *dev, const char *name, - u64 value, u32 max) -{ - if (max > INT_MAX) - max = INT_MAX; - if (value > max) { - drm_err(dev, "%s of %llu exceeds maximum of %u\n", name, value, max); - return -EINVAL; - } - return value; -} - -static int vesadrm_get_validated_int0(struct drm_device *dev, const char *name, - u64 value, u32 max) -{ - if (!value) { - drm_err(dev, "%s of 0 not allowed\n", name); - return -EINVAL; - } - return vesadrm_get_validated_int(dev, name, value, max); -} - static s64 vesadrm_get_validated_size0(struct drm_device *dev, const char *name, u64 value, u64 max) { @@ -73,12 +51,12 @@ static s64 vesadrm_get_validated_size0(struct drm_device *dev, const char *name, static int vesadrm_get_width_si(struct drm_device *dev, const struct screen_info *si) { - return vesadrm_get_validated_int0(dev, "width", si->lfb_width, U16_MAX); + return drm_sysfb_get_validated_int0(dev, "width", si->lfb_width, U16_MAX); } static int vesadrm_get_height_si(struct drm_device *dev, const struct screen_info *si) { - return vesadrm_get_validated_int0(dev, "height", si->lfb_height, U16_MAX); + return drm_sysfb_get_validated_int0(dev, "height", si->lfb_height, U16_MAX); } static struct resource *vesadrm_get_memory_si(struct drm_device *dev, @@ -105,7 +83,8 @@ static int vesadrm_get_stride_si(struct drm_device *dev, const struct screen_inf if (!lfb_linelength) lfb_linelength = drm_format_info_min_pitch(format, 0, width); - return vesadrm_get_validated_int0(dev, "stride", lfb_linelength, div64_u64(size, height)); + return drm_sysfb_get_validated_int0(dev, "stride", lfb_linelength, + div64_u64(size, height)); } static u64 vesadrm_get_visible_size_si(struct drm_device *dev, const struct screen_info *si, |