diff options
| author |   Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2020-04-24 18:31:46 +0100 |
|---|---|---|
| committer |   Jason Gunthorpe <jgg@mellanox.com> | 2020-04-24 15:31:26 -0300 |
| commit | 47c370c1a5eea9b2f6f026d49e060c3748c89667 (patch) | |
| tree | c3bb03c31161b8fbbf5f3f27277e4c6568507255 /drivers/infiniband/sw/rdmavt/cq.c | |
| parent | RDMA/core: Fix overwriting of uobj in case of error (diff) | |
| download | wireguard-linux-47c370c1a5eea9b2f6f026d49e060c3748c89667.tar.xz wireguard-linux-47c370c1a5eea9b2f6f026d49e060c3748c89667.zip | |
IB/rdmavt: Always return ERR_PTR from rvt_create_mmap_info()
The commit below modified rvt_create_mmap_info() to return ERR_PTR's but
didn't update the callers to handle them. Modify rvt_create_mmap_info() to
only return ERR_PTR and fix all error checking after
rvt_create_mmap_info() was called.
Fixes: ff23dfa13457 ("IB: Pass only ib_udata in function prototypes")
Link: https://lore.kernel.org/r/20200424173146.10970-1-sudipm.mukherjee@gmail.com
Cc: stable@vger.kernel.org [5.4+]
Tested-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Acked-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'drivers/infiniband/sw/rdmavt/cq.c')
| -rw-r--r-- | drivers/infiniband/sw/rdmavt/cq.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/infiniband/sw/rdmavt/cq.c b/drivers/infiniband/sw/rdmavt/cq.c index 5724cbbe38b1..04d2e72017fe 100644 --- a/drivers/infiniband/sw/rdmavt/cq.c +++ b/drivers/infiniband/sw/rdmavt/cq.c @@ -248,8 +248,8 @@ int rvt_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr, */ if (udata && udata->outlen >= sizeof(__u64)) { cq->ip = rvt_create_mmap_info(rdi, sz, udata, u_wc); - if (!cq->ip) { - err = -ENOMEM; + if (IS_ERR(cq->ip)) { + err = PTR_ERR(cq->ip); goto bail_wc; } |