aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers/media/pci/ddbridge
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2018-08-01 09:06:10 -0400
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2018-09-12 09:14:05 -0400
commitc4189ffb8c052ce4b2bd4ace6cd628a4fe3d9e65 (patch)
tree285e4c2e00e4f424617190023a6840e889bd9a6a /drivers/media/pci/ddbridge
parentmedia: MAINTAINERS: mark ddbridge, stv0910, stv6111 and mxl5xx orphan (diff)
downloadwireguard-linux-c4189ffb8c052ce4b2bd4ace6cd628a4fe3d9e65.tar.xz
wireguard-linux-c4189ffb8c052ce4b2bd4ace6cd628a4fe3d9e65.zip
media: ddbridge/sx8: remove redundant check of iq_mode == 2
The check for irq_mode == 2 occurs is always false and hence flags is always zero. This is because the check occurs in a path where irq_mode is >= 3. Clean up the code by removing the check and irq_mode and just pass 0. Detected by CoverityScan, CID#1472214 ("Logically dead code") Signed-off-by: Colin Ian King <colin.king@canonical.com> Cc: Ralph Metzler <rjkm@metzlerbros.de> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/pci/ddbridge')
-rw-r--r--drivers/media/pci/ddbridge/ddbridge-sx8.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/media/pci/ddbridge/ddbridge-sx8.c b/drivers/media/pci/ddbridge/ddbridge-sx8.c
index 64f05f5ee039..374fcee94960 100644
--- a/drivers/media/pci/ddbridge/ddbridge-sx8.c
+++ b/drivers/media/pci/ddbridge/ddbridge-sx8.c
@@ -398,9 +398,7 @@ static int set_parameters(struct dvb_frontend *fe)
}
stat = start(fe, 3, mask, ts_config);
} else {
- u32 flags = (iq_mode == 2) ? 1 : 0;
-
- stat = start_iq(fe, flags, 4, ts_config);
+ stat = start_iq(fe, 0, 4, ts_config);
}
if (!stat) {
state->started = 1;