diff options
| author |   Shannon Nelson <snelson@pensando.io> | 2020-10-22 16:55:30 -0700 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2020-10-23 18:37:23 -0700 |
| commit | 43ecf7b46f2688fd37909801aee264f288b3917b (patch) | |
| tree | bd2c2e4acdc751580419d9d3b2de3380d00c57b4 /drivers/net/ethernet/pensando/ionic/ionic_txrx.c | |
| parent | ionic: clean up sparse complaints (diff) | |
| download | wireguard-linux-43ecf7b46f2688fd37909801aee264f288b3917b.tar.xz wireguard-linux-43ecf7b46f2688fd37909801aee264f288b3917b.zip | |
ionic: no rx flush in deinit
Kmemleak pointed out to us that ionic_rx_flush() is sending
skbs into napi_gro_XXX with a disabled napi context, and these
end up getting lost and leaked. We can safely remove the flush.
Fixes: 0f3154e6bcb3 ("ionic: Add Tx and Rx handling")
Signed-off-by: Shannon Nelson <snelson@pensando.io>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c index 8f6fc7142bc5..35acb4d66e31 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c @@ -253,19 +253,6 @@ static bool ionic_rx_service(struct ionic_cq *cq, struct ionic_cq_info *cq_info) return true; } -void ionic_rx_flush(struct ionic_cq *cq) -{ - struct ionic_dev *idev = &cq->lif->ionic->idev; - u32 work_done; - - work_done = ionic_cq_service(cq, cq->num_descs, - ionic_rx_service, NULL, NULL); - - if (work_done) - ionic_intr_credits(idev->intr_ctrl, cq->bound_intr->index, - work_done, IONIC_INTR_CRED_RESET_COALESCE); -} - static int ionic_rx_page_alloc(struct ionic_queue *q, struct ionic_page_info *page_info) { |