diff options
| author |   Daniil Tatianin <d-tatianin@yandex-team.ru> | 2023-03-15 22:46:18 +0300 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2023-03-16 21:08:36 -0700 |
| commit | 470efd68a4653d9819d391489886432cd31bcd0b (patch) | |
| tree | 1e1144d7be45348e98c04f0d2f9b269f7a69aa03 /drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c | |
| parent | selftests: net: devlink_port_split.py: skip test if no suitable device available (diff) | |
| download | wireguard-linux-470efd68a4653d9819d391489886432cd31bcd0b.tar.xz wireguard-linux-470efd68a4653d9819d391489886432cd31bcd0b.zip | |
qed/qed_mng_tlv: correctly zero out ->min instead of ->hour
This fixes an issue where ->hour would erroneously get zeroed out
instead of ->min because of a bad copy paste.
Found by Linux Verification Center (linuxtesting.org) with the SVACE
static analysis tool.
Fixes: f240b6882211 ("qed: Add support for processing fcoe tlv request.")
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Link: https://lore.kernel.org/r/20230315194618.579286-1-d-tatianin@yandex-team.ru
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c b/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c index 6190adf965bc..f55eed092f25 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c +++ b/drivers/net/ethernet/qlogic/qed/qed_mng_tlv.c @@ -422,7 +422,7 @@ qed_mfw_get_tlv_time_value(struct qed_mfw_tlv_time *p_time, if (p_time->hour > 23) p_time->hour = 0; if (p_time->min > 59) - p_time->hour = 0; + p_time->min = 0; if (p_time->msec > 999) p_time->msec = 0; if (p_time->usec > 999) |