diff options
| author |   Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-04-04 14:42:44 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-04-05 11:59:33 -0700 |
| commit | 1ec3d02f9cdf2a4b89664145c7965aa46398d31e (patch) | |
| tree | edc592a141b173ad4fe61d3c68cb2affdafec7e0 /drivers/net/ethernet/qlogic/qede | |
| parent | sfc: Use 'skb_add_rx_frag()' instead of hand coding it (diff) | |
| download | wireguard-linux-1ec3d02f9cdf2a4b89664145c7965aa46398d31e.tar.xz wireguard-linux-1ec3d02f9cdf2a4b89664145c7965aa46398d31e.zip | |
qede: Remove a erroneous ++ in 'qede_rx_build_jumbo()'
This ++ is confusing. It looks duplicated with the one already performed in
'skb_fill_page_desc()'.
In fact, it is harmless. 'nr_frags' is written twice with the same value.
Once, because of the nr_frags++, and once because of the 'nr_frags = i + 1'
in 'skb_fill_page_desc()'.
So axe this post-increment to avoid confusion.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/qlogic/qede')
| -rw-r--r-- | drivers/net/ethernet/qlogic/qede/qede_fp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c b/drivers/net/ethernet/qlogic/qede/qede_fp.c index 102d0e0808d5..ee3e45e38cb7 100644 --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c @@ -1209,7 +1209,7 @@ static int qede_rx_build_jumbo(struct qede_dev *edev, dma_unmap_page(rxq->dev, bd->mapping, PAGE_SIZE, DMA_FROM_DEVICE); - skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags++, + skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags, bd->data, rxq->rx_headroom, cur_size); skb->truesize += PAGE_SIZE; |