diff options
| author |   Justin Stitt <justinstitt@google.com> | 2023-10-09 18:24:20 +0000 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2023-10-11 17:26:04 -0700 |
| commit | ed9417206de7d306d6f79340fbe4849d3bdfae4e (patch) | |
| tree | 89c4c295a592a55efe1ab741ee158e3f31fe380d /drivers/net/macsec.c | |
| parent | net: dsa: mt7530: replace deprecated strncpy with ethtool_sprintf (diff) | |
| download | wireguard-linux-ed9417206de7d306d6f79340fbe4849d3bdfae4e.tar.xz wireguard-linux-ed9417206de7d306d6f79340fbe4849d3bdfae4e.zip | |
net: dsa: lantiq_gswip: replace deprecated strncpy with ethtool_sprintf
`strncpy` is deprecated for use on NUL-terminated destination strings
[1] and as such we should prefer more robust and less ambiguous string
interfaces.
ethtool_sprintf() is designed specifically for get_strings() usage.
Let's replace strncpy in favor of this more robust and easier to
understand interface.
Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20231009-strncpy-drivers-net-dsa-lantiq_gswip-c-v1-1-d55a986a14cc@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/macsec.c')
0 files changed, 0 insertions, 0 deletions