diff options
| author |   Stanislav Fomichev <sdf@fomichev.me> | 2025-03-05 08:37:29 -0800 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2025-03-06 12:59:45 -0800 |
| commit | df43d8bf10316a7c3b1e47e3cc0057a54df4a5b8 (patch) | |
| tree | d31253686f41f2bdad50762ea5b86bf56cc7ad25 /drivers/net/tap.c | |
| parent | net: ethtool: try to protect all callback with netdev instance lock (diff) | |
| download | wireguard-linux-df43d8bf10316a7c3b1e47e3cc0057a54df4a5b8.tar.xz wireguard-linux-df43d8bf10316a7c3b1e47e3cc0057a54df4a5b8.zip | |
net: replace dev_addr_sem with netdev instance lock
Lockdep reports possible circular dependency in [0]. Instead of
fixing the ordering, replace global dev_addr_sem with netdev
instance lock. Most of the paths that set/get mac are RTNL
protected. Two places where it's not, convert to explicit
locking:
- sysfs address_show
- dev_get_mac_address via dev_ioctl
0: https://netdev-3.bots.linux.dev/vmksft-forwarding-dbg/results/993321/24-router-bridge-1d-lag-sh/stderr
Signed-off-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250305163732.2766420-12-sdf@fomichev.me
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/tap.c')
| -rw-r--r-- | drivers/net/tap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/tap.c b/drivers/net/tap.c index d4ece538f1b2..4382f5e323b0 100644 --- a/drivers/net/tap.c +++ b/drivers/net/tap.c @@ -1017,7 +1017,7 @@ static long tap_ioctl(struct file *file, unsigned int cmd, rtnl_unlock(); return -ENOLINK; } - ret = dev_set_mac_address_user(tap->dev, &sa, NULL); + ret = dev_set_mac_address(tap->dev, &sa, NULL); tap_put_tap_dev(tap); rtnl_unlock(); return ret; |