diff options
| author |   Asbjørn Sloth Tønnesen <ast@fiberby.net> | 2025-11-26 17:35:36 +0000 |
|---|---|---|
| committer |   Jason A. Donenfeld <Jason@zx2c4.com> | 2025-12-01 03:25:09 +0100 |
| commit | b8bcc17f583b87f9913659d69cd796fbc203e510 (patch) | |
| tree | f754703107464610ab1e9de138daa7e238272dc7 /drivers/net/wireguard/netlink.c | |
| parent | wireguard: netlink: convert to split ops (diff) | |
| download | wireguard-linux-b8bcc17f583b87f9913659d69cd796fbc203e510.tar.xz wireguard-linux-b8bcc17f583b87f9913659d69cd796fbc203e510.zip | |
wireguard: netlink: lower .maxattr for WG_CMD_GET_DEVICE
Previously .maxattr was shared for both WG_CMD_GET_DEVICE and
WG_CMD_SET_DEVICE. Now that it is split, then we can lower it
for WG_CMD_GET_DEVICE to follow the documentation which defines
.maxattr as WGDEVICE_A_IFNAME for WG_CMD_GET_DEVICE.
$ grep -hC5 'one but not both of:' include/uapi/linux/wireguard.h
* WG_CMD_GET_DEVICE
* -----------------
*
* May only be called via NLM_F_REQUEST | NLM_F_DUMP. The command
* should contain one but not both of:
*
* WGDEVICE_A_IFINDEX: NLA_U32
* WGDEVICE_A_IFNAME: NLA_NUL_STRING, maxlen IFNAMSIZ - 1
*
* The kernel will then return several messages [...]
While other attributes weren't rejected previously, the consensus
is that nobody sends those attributes, so nothing should break.
Link: https://lore.kernel.org/r/aRyLoy2iqbkUipZW@zx2c4.com/
Suggested-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Asbjørn Sloth Tønnesen <ast@fiberby.net>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/net/wireguard/netlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireguard/netlink.c b/drivers/net/wireguard/netlink.c index e7efe5f8465d..c2d0576e96f5 100644 --- a/drivers/net/wireguard/netlink.c +++ b/drivers/net/wireguard/netlink.c @@ -623,7 +623,7 @@ static const struct genl_split_ops wireguard_nl_ops[] = { .dumpit = wg_get_device_dump, .done = wg_get_device_done, .policy = device_policy, - .maxattr = WGDEVICE_A_PEERS, + .maxattr = WGDEVICE_A_IFNAME, .flags = GENL_UNS_ADMIN_PERM | GENL_CMD_CAP_DUMP, }, { .cmd = WG_CMD_SET_DEVICE, |