diff options
| author |   Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2022-09-16 23:54:48 +0300 |
|---|---|---|
| committer |   Linus Walleij <linus.walleij@linaro.org> | 2022-09-20 11:22:12 +0200 |
| commit | 56e380cfcd82a228dc006902b88cf1adaf9851dc (patch) | |
| tree | 6e2e2c3069e6d1d8e4a9cc3d85a26652a066cb44 /drivers/pinctrl | |
| parent | pinctrl: sunxi: sun50i-h5: Switch to use dev_err_probe() helper (diff) | |
| download | wireguard-linux-56e380cfcd82a228dc006902b88cf1adaf9851dc.tar.xz wireguard-linux-56e380cfcd82a228dc006902b88cf1adaf9851dc.zip | |
pinctrl: cy8c95x0: Lock register accesses in cy8c95x0_set_mux()
It seems that cy8c95x0_set_mux() missed serialization of IO access.
And its implementation looks half-baked. Add locking to the function.
Fixes: e6cbbe42944d ("pinctrl: Add Cypress cy8c95x0 support")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20220916205450.86278-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/pinctrl-cy8c95x0.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/pinctrl/pinctrl-cy8c95x0.c b/drivers/pinctrl/pinctrl-cy8c95x0.c index 79f73d364f3f..75be06d29dc1 100644 --- a/drivers/pinctrl/pinctrl-cy8c95x0.c +++ b/drivers/pinctrl/pinctrl-cy8c95x0.c @@ -1152,8 +1152,13 @@ static int cy8c95x0_set_mux(struct pinctrl_dev *pctldev, unsigned int selector, unsigned int group) { struct cy8c95x0_pinctrl *chip = pinctrl_dev_get_drvdata(pctldev); + int ret; - return cy8c95x0_pinmux_cfg(chip, selector, group); + mutex_lock(&chip->i2c_lock); + ret = cy8c95x0_pinmux_cfg(chip, selector, group); + mutex_unlock(&chip->i2c_lock); + + return ret; } static const struct pinmux_ops cy8c95x0_pmxops = { |