diff options
author | 2022-06-04 16:18:05 +0200 | |
---|---|---|
committer | 2022-09-03 12:17:27 +0200 | |
commit | a2ed70d0ecb11b7eb3ff14ed897cd0995c86651d (patch) | |
tree | 622fab9c9395658b379a683c70e7f711355d2188 /drivers/platform/x86/acer-wmi.c | |
parent | platform/x86: apple-gmux: Stop calling acpi/video.h functions (diff) | |
download | wireguard-linux-a2ed70d0ecb11b7eb3ff14ed897cd0995c86651d.tar.xz wireguard-linux-a2ed70d0ecb11b7eb3ff14ed897cd0995c86651d.zip |
platform/x86: toshiba_acpi: Stop using acpi_video_set_dmi_backlight_type()
acpi_video_set_dmi_backlight_type() is troublesome because it may end up
getting called after other backlight drivers have already called
acpi_video_get_backlight_type() resulting in the other drivers
already being registered even though they should not.
In case of the acpi_video backlight, acpi_video_set_dmi_backlight_type()
actually calls acpi_video_unregister_backlight() since that is often
probed earlier, leading to userspace seeing the acpi_video0 class
device being briefly available, leading to races in userspace where
udev probe-rules try to access the device and it is already gone.
In case of toshiba_acpi there are no DMI quirks to move to
acpi/video_detect.c, but it also (ab)uses it for transflective
displays. Adding transflective display support to video_detect.c would
be quite involved. But luckily there are only 2 known models with
a transflective display, so we can just add DMI quirks for those.
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86/acer-wmi.c')
0 files changed, 0 insertions, 0 deletions