diff options
| author |   Fabio Estevam <festevam@gmail.com> | 2024-12-12 10:04:56 -0300 |
|---|---|---|
| committer |   Sebastian Reichel <sebastian.reichel@collabora.com> | 2024-12-12 23:34:50 +0100 |
| commit | 8a1c099f36b256c8203319313f65666ce0043fe5 (patch) | |
| tree | 230cfc501f063e19af16f3ae2a69ec9dd802aa6a /drivers/power/reset/gpio-poweroff.c | |
| parent | power: supply: power_supply_show_enum_with_available(): Replace spaces with '_' (diff) | |
| download | wireguard-linux-8a1c099f36b256c8203319313f65666ce0043fe5.tar.xz wireguard-linux-8a1c099f36b256c8203319313f65666ce0043fe5.zip | |
power: reset: gpio-poweroff: Clarify the warning message
When gpio-poweroff fails, a WARN_ON() is triggered without
an explanation to the user about the failure.
Add some comments explaining that the attempt to poweroff the system
via gpio-poweroff failed and convert it to a WARN() message with a
bit of context to provide some hint to the user.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20241212130456.580197-1-festevam@gmail.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/power/reset/gpio-poweroff.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/power/reset/gpio-poweroff.c b/drivers/power/reset/gpio-poweroff.c index 52cfeee2cb28..3eaae352ffb9 100644 --- a/drivers/power/reset/gpio-poweroff.c +++ b/drivers/power/reset/gpio-poweroff.c @@ -44,7 +44,13 @@ static int gpio_poweroff_do_poweroff(struct sys_off_data *data) /* give it some time */ mdelay(gpio_poweroff->timeout_ms); - WARN_ON(1); + /* + * If code reaches this point, it means that gpio-poweroff has failed + * to actually power off the system. + * Warn the user that the attempt to poweroff via gpio-poweroff + * has gone wrong. + */ + WARN(1, "Failed to poweroff via gpio-poweroff mechanism\n"); return NOTIFY_DONE; } |