diff options
author | 2020-09-23 10:17:47 +0200 | |
---|---|---|
committer | 2020-09-23 10:19:19 +0200 | |
commit | 01cc2ec6ea044731e939e5e47f7e115b86f49465 (patch) | |
tree | 4f44814fae427ccd7c45b5b64612aebd9ebc2b7f /drivers/staging/media/atomisp/pci/ia_css_env.h | |
parent | media: atomisp: fix gcc warnings (diff) | |
download | wireguard-linux-01cc2ec6ea044731e939e5e47f7e115b86f49465.tar.xz wireguard-linux-01cc2ec6ea044731e939e5e47f7e115b86f49465.zip |
media: atomisp: cleanup __printf() atributes on printk messages
There are still some warnings produced by -Wsuggest-attribute=format,
like this one:
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c: In function ‘dtrace_dot’:
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c:2466:2: warning: function ‘dtrace_dot’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
2466 | ia_css_debug_vdtrace(IA_CSS_DEBUG_INFO, fmt, ap);
| ^~~~~~~~~~~~~~~~~~~~
Also, on some places, is is using __atribute, while on others it
is using the __printf() macro.
Uniform those to always use the __printf() macro, placing it
before the function, and fix the logic in order to cleanup
all such warnings.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/staging/media/atomisp/pci/ia_css_env.h')
-rw-r--r-- | drivers/staging/media/atomisp/pci/ia_css_env.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/staging/media/atomisp/pci/ia_css_env.h b/drivers/staging/media/atomisp/pci/ia_css_env.h index 9808ff9e0492..6b38723b27cd 100644 --- a/drivers/staging/media/atomisp/pci/ia_css_env.h +++ b/drivers/staging/media/atomisp/pci/ia_css_env.h @@ -75,9 +75,9 @@ struct ia_css_hw_access_env { /* Environment with function pointers to print error and debug messages. */ struct ia_css_print_env { - int (*debug_print)(const char *fmt, va_list args) __attribute__((format (printf, 1, 0))); + int __printf(1, 0) (*debug_print)(const char *fmt, va_list args); /** Print a debug message. */ - int (*error_print)(const char *fmt, va_list args) __attribute__((format (printf, 1, 0))); + int __printf(1, 0) (*error_print)(const char *fmt, va_list args); /** Print an error message.*/ }; |