diff options
| author |   Arnd Bergmann <arnd@arndb.de> | 2020-05-29 22:00:27 +0200 |
|---|---|---|
| committer |   Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-06-11 19:03:03 +0200 |
| commit | 89f3b3196e7fe63a66296c7ed95b96964963c6ea (patch) | |
| tree | 8c042b9fa89e3e72e510ec5608d652881e8892e4 /drivers/staging/media/atomisp/pci/runtime/pipeline/interface/ia_css_pipeline.h | |
| parent | media: atomisp: re-enable warnings again (diff) | |
| download | wireguard-linux-89f3b3196e7fe63a66296c7ed95b96964963c6ea.tar.xz wireguard-linux-89f3b3196e7fe63a66296c7ed95b96964963c6ea.zip | |
media: staging: media: atomisp: fix stack overflow in init_pipe_defaults()
When building with clang, multiple copies of the structures to be
initialized are passed around on the stack and copied locally, using an
insane amount of stack space:
drivers/staging/media/atomisp/pci/sh_css.c:2371:1: error: stack frame size of 26864 bytes in function 'create_pipe' [-Werror,-Wframe-larger-than=]
Use constantly-allocated variables plus an explicit memcpy()
to avoid that.
Co-authored-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Fixes: 6dc9a2568f84 ("media: atomisp: convert default struct values to use compound-literals with designated initializers")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/staging/media/atomisp/pci/runtime/pipeline/interface/ia_css_pipeline.h')
| -rw-r--r-- | drivers/staging/media/atomisp/pci/runtime/pipeline/interface/ia_css_pipeline.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/staging/media/atomisp/pci/runtime/pipeline/interface/ia_css_pipeline.h b/drivers/staging/media/atomisp/pci/runtime/pipeline/interface/ia_css_pipeline.h index 1f4afd163ffa..18a7d18e197e 100644 --- a/drivers/staging/media/atomisp/pci/runtime/pipeline/interface/ia_css_pipeline.h +++ b/drivers/staging/media/atomisp/pci/runtime/pipeline/interface/ia_css_pipeline.h @@ -57,8 +57,7 @@ struct ia_css_pipeline { u32 pipe_qos_config; }; -#define DEFAULT_PIPELINE \ -(struct ia_css_pipeline) { \ +#define DEFAULT_PIPELINE { \ .pipe_id = IA_CSS_PIPE_ID_PREVIEW, \ .in_frame = DEFAULT_FRAME, \ .out_frame = {DEFAULT_FRAME}, \ |