aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers/staging/media/rkisp1/rkisp1-dev.c
diff options
context:
space:
mode:
authorDafna Hirschfeld <dafna.hirschfeld@collabora.com>2020-09-22 13:33:57 +0200
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2020-09-27 11:34:28 +0200
commit8524fa22fd2f49ca39834fe93c952ddac1c43750 (patch)
treefe003b61a29aed21b622680ed80af22b29057fa2 /drivers/staging/media/rkisp1/rkisp1-dev.c
parentmedia: staging: rkisp1: remove atomic operations for frame sequence (diff)
downloadwireguard-linux-8524fa22fd2f49ca39834fe93c952ddac1c43750.tar.xz
wireguard-linux-8524fa22fd2f49ca39834fe93c952ddac1c43750.zip
media: staging: rkisp1: isp: add a warning and debugfs var for irq delay
The signal RKISP1_CIF_ISP_FRAME is set when the ISP completes outputting the frame to the next block in the pipeline. In order to keep buffer synchronization we assume that the RKISP1_CIF_ISP_V_START signal never arrives together with the RKISP1_CIF_ISP_FRAME signal. In case those signals arrive together then the code is not able to tell if the RKISP1_CIF_ISP_FRAME signal relates to the frame of the current v-start or the previous. This patch adds a WARN_ONCE and a debugfs var to catch it. Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/staging/media/rkisp1/rkisp1-dev.c')
-rw-r--r--drivers/staging/media/rkisp1/rkisp1-dev.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/staging/media/rkisp1/rkisp1-dev.c b/drivers/staging/media/rkisp1/rkisp1-dev.c
index d85ac10e5494..91584695804b 100644
--- a/drivers/staging/media/rkisp1/rkisp1-dev.c
+++ b/drivers/staging/media/rkisp1/rkisp1-dev.c
@@ -444,6 +444,8 @@ static void rkisp1_debug_init(struct rkisp1_device *rkisp1)
&debug->img_stabilization_size_error);
debugfs_create_ulong("inform_size_error", 0444, debug->debugfs_dir,
&debug->inform_size_error);
+ debugfs_create_ulong("irq_delay", 0444, debug->debugfs_dir,
+ &debug->irq_delay);
debugfs_create_ulong("mipi_error", 0444, debug->debugfs_dir,
&debug->mipi_error);
debugfs_create_ulong("stats_error", 0444, debug->debugfs_dir,