diff options
| author |   Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-05-19 09:15:41 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-05-20 14:51:29 +0200 |
| commit | 95d1f398c4dc3f55e9007c89452ccc16301205fc (patch) | |
| tree | 9bfe7ea178105975ef649544dac5701c0fe83dfe /drivers/staging | |
| parent | media: atomisp: fix the value for CamClk on Asus T101HA (diff) | |
| download | wireguard-linux-95d1f398c4dc3f55e9007c89452ccc16301205fc.tar.xz wireguard-linux-95d1f398c4dc3f55e9007c89452ccc16301205fc.zip | |
media: atomisp: keep the ISP powered on when setting it
The current code causes ISP2401 to power down and never return
back to live, causing the driver to crash.
Fix it by commenting out the bad code. It should be noticed that
the Yocto Aero code has something similar to it.
Maybe the issue is related to an ISP bug (or maybe PM is
controlled on a different way for this hardware).
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c index 8c7b42221659..4395ca0e3e11 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -824,13 +824,17 @@ static int atomisp_mrfld_power(struct atomisp_device *isp, bool enable) /* Workaround for pmu_nc_set_power_state not ready in MRFLD */ int atomisp_mrfld_power_down(struct atomisp_device *isp) { - return atomisp_mrfld_power(isp, false); + return 0; +// FIXME: at least with ISP2401, the code below causes the driver to break +// return atomisp_mrfld_power(isp, false); } /* Workaround for pmu_nc_set_power_state not ready in MRFLD */ int atomisp_mrfld_power_up(struct atomisp_device *isp) { - return atomisp_mrfld_power(isp, true); + return 0; +// FIXME: at least with ISP2401, the code below causes the driver to break +// return atomisp_mrfld_power(isp, true); } int atomisp_runtime_suspend(struct device *dev) |