diff options
| author |   Pawel Laszczak <pawell@cadence.com> | 2021-05-05 07:58:54 +0200 |
|---|---|---|
| committer |   Peter Chen <peter.chen@kernel.org> | 2021-05-11 14:12:54 +0800 |
| commit | 4ae08bc23e1b29894b1af34990409a454cccf242 (patch) | |
| tree | a5f57b5fa086c032e8014a86359c642d5c5bc977 /drivers/usb/cdns3 | |
| parent | usb: cdns3: Corrected comment to align with kernel-doc comment (diff) | |
| download | wireguard-linux-4ae08bc23e1b29894b1af34990409a454cccf242.tar.xz wireguard-linux-4ae08bc23e1b29894b1af34990409a454cccf242.zip | |
usb: cdnsp: Useless condition has been removed
This code generates a Smatch warning:
drivers/usb/cdns3/cdnsp-mem.c:1085 cdnsp_mem_cleanup()
warn: variable dereferenced before check 'pdev->dcbaa' (see line 1067)
The unchecked dereference happens inside the function when we call:
cdnsp_free_priv_device(pdev);
But fortunately, the "pdev->dcbaa" pointer can never be NULL so it
does not lead to a runtime issue. We can just remove the NULL check
which silences the warning and makes the code consistent.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Link: https://lore.kernel.org/r/20210505055854.40240-1-pawell@gli-login.cadence.com
Signed-off-by: Peter Chen <peter.chen@kernel.org>
Diffstat (limited to 'drivers/usb/cdns3')
| -rw-r--r-- | drivers/usb/cdns3/cdnsp-mem.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c index 5d4c4bfe15b7..a47948a1623f 100644 --- a/drivers/usb/cdns3/cdnsp-mem.c +++ b/drivers/usb/cdns3/cdnsp-mem.c @@ -1082,9 +1082,8 @@ void cdnsp_mem_cleanup(struct cdnsp_device *pdev) dma_pool_destroy(pdev->device_pool); pdev->device_pool = NULL; - if (pdev->dcbaa) - dma_free_coherent(dev, sizeof(*pdev->dcbaa), - pdev->dcbaa, pdev->dcbaa->dma); + dma_free_coherent(dev, sizeof(*pdev->dcbaa), + pdev->dcbaa, pdev->dcbaa->dma); pdev->dcbaa = NULL; |