aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers/usb/cdns3
diff options
context:
space:
mode:
authorPawel Laszczak <pawell@cadence.com>2022-01-11 10:07:37 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-01-26 14:11:16 +0100
commit79aa3e19fe8f5be30e846df8a436bfe306e8b1a6 (patch)
tree2a70e7dff6af5a4424eb109223ecbd9fc4199fb3 /drivers/usb/cdns3
parentusb: dwc2: gadget: don't try to disable ep0 in dwc2_hsotg_suspend (diff)
downloadwireguard-linux-79aa3e19fe8f5be30e846df8a436bfe306e8b1a6.tar.xz
wireguard-linux-79aa3e19fe8f5be30e846df8a436bfe306e8b1a6.zip
usb: cdnsp: Fix segmentation fault in cdns_lost_power function
CDNSP driver read not initialized cdns->otg_v0_regs which lead to segmentation fault. Patch fixes this issue. Fixes: 2cf2581cd229 ("usb: cdns3: add power lost support for system resume") cc: <stable@vger.kernel.org> Signed-off-by: Pawel Laszczak <pawell@cadence.com> Link: https://lore.kernel.org/r/20220111090737.10345-1-pawell@gli-login.cadence.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/cdns3')
-rw-r--r--drivers/usb/cdns3/drd.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
index 55c73b1d8704..d00ff98dffab 100644
--- a/drivers/usb/cdns3/drd.c
+++ b/drivers/usb/cdns3/drd.c
@@ -483,11 +483,11 @@ int cdns_drd_exit(struct cdns *cdns)
/* Indicate the cdns3 core was power lost before */
bool cdns_power_is_lost(struct cdns *cdns)
{
- if (cdns->version == CDNS3_CONTROLLER_V1) {
- if (!(readl(&cdns->otg_v1_regs->simulate) & BIT(0)))
+ if (cdns->version == CDNS3_CONTROLLER_V0) {
+ if (!(readl(&cdns->otg_v0_regs->simulate) & BIT(0)))
return true;
} else {
- if (!(readl(&cdns->otg_v0_regs->simulate) & BIT(0)))
+ if (!(readl(&cdns->otg_v1_regs->simulate) & BIT(0)))
return true;
}
return false;