diff options
| author |   Wesley Cheng <quic_wcheng@quicinc.com> | 2022-01-10 22:48:50 -0800 |
|---|---|---|
| committer |   Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-26 13:57:59 +0100 |
| commit | d6dd18efd01fc64bc3d1df0d18ad67f854e6e137 (patch) | |
| tree | 01ea3f567f3bbd8c97b8554690518f8b2b416e28 /drivers/usb/gadget/function/f_serial.c | |
| parent | usb: gadget: tegra-xudc: Do not program SPARAM (diff) | |
| download | wireguard-linux-d6dd18efd01fc64bc3d1df0d18ad67f854e6e137.tar.xz wireguard-linux-d6dd18efd01fc64bc3d1df0d18ad67f854e6e137.zip | |
usb: gadget: f_serial: Ensure gserial disconnected during unbind
Some UDCs may return an error during pullup disable as part of the
unbind path for a USB configuration. This will lead to a scenario
where the disable() callback is skipped, whereas the unbind() still
occurs. If this happens, the u_serial driver will continue to fail
subsequent binds, due to an already existing entry in the ports array.
Ensure that gserial_disconnect() is called during the f_serial unbind,
so the ports entry is properly cleared.
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Link: https://lore.kernel.org/r/20220111064850.24311-1-quic_wcheng@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget/function/f_serial.c')
| -rw-r--r-- | drivers/usb/gadget/function/f_serial.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/usb/gadget/function/f_serial.c b/drivers/usb/gadget/function/f_serial.c index 1ed8ff0ac2d3..a9480b9e312e 100644 --- a/drivers/usb/gadget/function/f_serial.c +++ b/drivers/usb/gadget/function/f_serial.c @@ -345,6 +345,10 @@ static void gser_free(struct usb_function *f) static void gser_unbind(struct usb_configuration *c, struct usb_function *f) { + struct f_gser *gser = func_to_gser(f); + + /* Ensure port is disconnected before unbinding */ + gserial_disconnect(&gser->port); usb_free_all_descriptors(f); } |