aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers/usb/host/ehci-exynos.c
diff options
context:
space:
mode:
authorKrzysztof Kozlowski <krzk@kernel.org>2017-01-07 10:41:40 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2017-01-10 17:00:42 +0100
commit3f6026b1dcb3c8ee71198c485a72ac674c6890dd (patch)
treecc63b3db7b0cd5dcfd425df7fd0d26028141bebf /drivers/usb/host/ehci-exynos.c
parentusb: make the MTK XHCI driver compile for older MIPS SoCs (diff)
downloadwireguard-linux-3f6026b1dcb3c8ee71198c485a72ac674c6890dd.tar.xz
wireguard-linux-3f6026b1dcb3c8ee71198c485a72ac674c6890dd.zip
usb: host: ehci-exynos: Decrese node refcount on exynos_ehci_get_phy() error paths
Returning from for_each_available_child_of_node() loop requires cleaning up node refcount. Error paths lacked it so for example in case of deferred probe, the refcount of phy node was left increased. Fixes: 6d40500ac9b6 ("usb: ehci/ohci-exynos: Fix of_node_put() for child when getting PHYs") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Alan Stern <stern@rowland.harvard.edu> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/host/ehci-exynos.c')
-rw-r--r--drivers/usb/host/ehci-exynos.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index 42e5b66353ef..7a603f66a9bc 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -77,10 +77,12 @@ static int exynos_ehci_get_phy(struct device *dev,
if (IS_ERR(phy)) {
ret = PTR_ERR(phy);
if (ret == -EPROBE_DEFER) {
+ of_node_put(child);
return ret;
} else if (ret != -ENOSYS && ret != -ENODEV) {
dev_err(dev,
"Error retrieving usb2 phy: %d\n", ret);
+ of_node_put(child);
return ret;
}
}