diff options
| author |   Dinghao Liu <dinghao.liu@zju.edu.cn> | 2020-05-21 15:39:19 +0800 |
|---|---|---|
| committer |   Felipe Balbi <balbi@kernel.org> | 2020-05-25 11:09:43 +0300 |
| commit | e5b913496099527abe46e175e5e2c844367bded0 (patch) | |
| tree | e32de46ca207457f0742252ad1f83496d3ebc6af /drivers/usb | |
| parent | usb: gadget: lpc32xx_udc: don't dereference ep pointer before null check (diff) | |
| download | wireguard-linux-e5b913496099527abe46e175e5e2c844367bded0.tar.xz wireguard-linux-e5b913496099527abe46e175e5e2c844367bded0.zip | |
usb: cdns3: Fix runtime PM imbalance on error
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.
Reviewed-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/cdns3/cdns3-ti.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/usb/cdns3/cdns3-ti.c b/drivers/usb/cdns3/cdns3-ti.c index 5685ba11480b..e701ab56b0a7 100644 --- a/drivers/usb/cdns3/cdns3-ti.c +++ b/drivers/usb/cdns3/cdns3-ti.c @@ -138,7 +138,7 @@ static int cdns_ti_probe(struct platform_device *pdev) error = pm_runtime_get_sync(dev); if (error < 0) { dev_err(dev, "pm_runtime_get_sync failed: %d\n", error); - goto err_get; + goto err; } /* assert RESET */ @@ -185,7 +185,6 @@ static int cdns_ti_probe(struct platform_device *pdev) err: pm_runtime_put_sync(data->dev); -err_get: pm_runtime_disable(data->dev); return error; |