diff options
| author |   Steve Sistare <steven.sistare@oracle.com> | 2024-02-09 14:30:07 -0800 |
|---|---|---|
| committer |   Michael S. Tsirkin <mst@redhat.com> | 2024-03-19 02:45:49 -0400 |
| commit | 9588e7fc511f9c55b9835f14916e90ab940061b7 (patch) | |
| tree | 0acd08e0b58f917131d07d8dfe902908033b264c /drivers/vdpa/vdpa_sim/vdpa_sim.c | |
| parent | virtio: uapi: Drop __packed attribute in linux/virtio_pci.h (diff) | |
| download | wireguard-linux-9588e7fc511f9c55b9835f14916e90ab940061b7.tar.xz wireguard-linux-9588e7fc511f9c55b9835f14916e90ab940061b7.zip | |
vdpa_sim: reset must not run
vdpasim_do_reset sets running to true, which is wrong, as it allows
vdpasim_kick_vq to post work requests before the device has been
configured. To fix, do not set running until VIRTIO_CONFIG_S_DRIVER_OK
is set.
Fixes: 0c89e2a3a9d0 ("vdpa_sim: Implement suspend vdpa op")
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Message-Id: <1707517807-137331-1-git-send-email-steven.sistare@oracle.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to '')
| -rw-r--r-- | drivers/vdpa/vdpa_sim/vdpa_sim.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c index be2925d0d283..18584ce70bf0 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c @@ -160,7 +160,7 @@ static void vdpasim_do_reset(struct vdpasim *vdpasim, u32 flags) } } - vdpasim->running = true; + vdpasim->running = false; spin_unlock(&vdpasim->iommu_lock); vdpasim->features = 0; @@ -483,6 +483,7 @@ static void vdpasim_set_status(struct vdpa_device *vdpa, u8 status) mutex_lock(&vdpasim->mutex); vdpasim->status = status; + vdpasim->running = (status & VIRTIO_CONFIG_S_DRIVER_OK) != 0; mutex_unlock(&vdpasim->mutex); } |