aboutsummaryrefslogtreecommitdiffstatshomepage
path: root/drivers/vfio/pci/mlx5/main.c
diff options
context:
space:
mode:
authorYishai Hadas <yishaih@nvidia.com>2022-06-28 18:59:09 +0300
committerAlex Williamson <alex.williamson@redhat.com>2022-06-30 10:45:39 -0600
commit2b1c1906286fa547845f5385ee72db74b2b0251d (patch)
tree6908bce8c4b9cd147c1baad2c1c8073fac3d4e6a /drivers/vfio/pci/mlx5/main.c
parentvfio: de-extern-ify function prototypes (diff)
downloadwireguard-linux-2b1c1906286fa547845f5385ee72db74b2b0251d.tar.xz
wireguard-linux-2b1c1906286fa547845f5385ee72db74b2b0251d.zip
vfio/mlx5: Protect mlx5vf_disable_fds() upon close device
Protect mlx5vf_disable_fds() upon close device to be called under the state mutex as done in all other places. This will prevent a race with any other flow which calls mlx5vf_disable_fds() as of health/recovery upon MLX5_PF_NOTIFY_DISABLE_VF event. Encapsulate this functionality in a separate function named mlx5vf_cmd_close_migratable() to consider migration caps and for further usage upon close device. Fixes: 6fadb021266d ("vfio/mlx5: Implement vfio_pci driver for mlx5 devices") Reviewed-by: Kevin Tian <kevin.tian@intel.com> Signed-off-by: Yishai Hadas <yishaih@nvidia.com> Link: https://lore.kernel.org/r/20220628155910.171454-2-yishaih@nvidia.com Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to '')
-rw-r--r--drivers/vfio/pci/mlx5/main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vfio/pci/mlx5/main.c b/drivers/vfio/pci/mlx5/main.c
index 0558d0649ddb..d754990f0662 100644
--- a/drivers/vfio/pci/mlx5/main.c
+++ b/drivers/vfio/pci/mlx5/main.c
@@ -570,7 +570,7 @@ static void mlx5vf_pci_close_device(struct vfio_device *core_vdev)
struct mlx5vf_pci_core_device *mvdev = container_of(
core_vdev, struct mlx5vf_pci_core_device, core_device.vdev);
- mlx5vf_disable_fds(mvdev);
+ mlx5vf_cmd_close_migratable(mvdev);
vfio_pci_core_close_device(core_vdev);
}