diff options
| author |   Kent Overstreet <kent.overstreet@linux.dev> | 2025-03-29 19:01:09 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2025-03-30 16:33:22 -0400 |
| commit | 707549600c4a012ed71c0204a7992a679880bf33 (patch) | |
| tree | 5ef1e20698e5473e96ac087efaab6e7139c01acd /fs/bcachefs/fs-ioctl.c | |
| parent | bcachefs: Clear fs_path_parent on subvolume unlink (diff) | |
| download | wireguard-linux-707549600c4a012ed71c0204a7992a679880bf33.tar.xz wireguard-linux-707549600c4a012ed71c0204a7992a679880bf33.zip | |
bcachefs: bch2_ioctl_subvolume_destroy() fixes
bch2_evict_subvolume_inodes() was getting stuck - due to incorrectly
pruning the dcache.
Also, fix missing permissions checks.
Reported-by: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to '')
| -rw-r--r-- | fs/bcachefs/fs-ioctl.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c index e3a3230fc652..0273130f18dc 100644 --- a/fs/bcachefs/fs-ioctl.c +++ b/fs/bcachefs/fs-ioctl.c @@ -541,10 +541,12 @@ static long bch2_ioctl_subvolume_destroy(struct bch_fs *c, struct file *filp, ret = -ENOENT; goto err; } - ret = __bch2_unlink(dir, victim, true); + + ret = inode_permission(file_mnt_idmap(filp), d_inode(victim), MAY_WRITE) ?: + __bch2_unlink(dir, victim, true); if (!ret) { fsnotify_rmdir(dir, victim); - d_delete(victim); + d_invalidate(victim); } err: inode_unlock(dir); |