diff options
| author |   Dexuan Cui <decui@microsoft.com> | 2018-12-17 20:16:09 +0000 |
|---|---|---|
| committer |   Sasha Levin <sashal@kernel.org> | 2019-01-09 14:20:47 -0500 |
| commit | ba50bf1ce9a51fc97db58b96d01306aa70bc3979 (patch) | |
| tree | e43d0dce0b0db7d34d931254351210ab1a4e2fc1 /include/linux/hyperv.h | |
| parent | Linux 5.0-rc1 (diff) | |
| download | wireguard-linux-ba50bf1ce9a51fc97db58b96d01306aa70bc3979.tar.xz wireguard-linux-ba50bf1ce9a51fc97db58b96d01306aa70bc3979.zip | |
Drivers: hv: vmbus: Check for ring when getting debug info
fc96df16a1ce is good and can already fix the "return stack garbage" issue,
but let's also improve hv_ringbuffer_get_debuginfo(), which would silently
return stack garbage, if people forget to check channel->state or
ring_info->ring_buffer, when using the function in the future.
Having an error check in the function would eliminate the potential risk.
Add a Fixes tag to indicate the patch depdendency.
Fixes: fc96df16a1ce ("Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels")
Cc: stable@vger.kernel.org
Cc: K. Y. Srinivasan <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include/linux/hyperv.h')
| -rw-r--r-- | include/linux/hyperv.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/include/linux/hyperv.h b/include/linux/hyperv.h index f0885cc01db6..dcb6977afce9 100644 --- a/include/linux/hyperv.h +++ b/include/linux/hyperv.h @@ -1159,8 +1159,9 @@ struct hv_ring_buffer_debug_info { u32 bytes_avail_towrite; }; -void hv_ringbuffer_get_debuginfo(const struct hv_ring_buffer_info *ring_info, - struct hv_ring_buffer_debug_info *debug_info); + +int hv_ringbuffer_get_debuginfo(const struct hv_ring_buffer_info *ring_info, + struct hv_ring_buffer_debug_info *debug_info); /* Vmbus interface */ #define vmbus_driver_register(driver) \ |