diff options
author | Julia Lawall <Julia.Lawall@inria.fr> | 2020-07-26 12:58:29 +0200 |
---|---|---|
committer | Saeed Mahameed <saeedm@mellanox.com> | 2020-07-28 02:37:57 -0700 |
commit | 22f9d2f4ee810e6442185ba7ecab37e24de1b413 (patch) | |
tree | 2ff8fa21a1ab99ede1a33d8ef154b3c99c0663c1 /include/linux/jhash.h | |
parent | net/mlx5: Use fallthrough pseudo-keyword (diff) | |
download | wireguard-linux-22f9d2f4ee810e6442185ba7ecab37e24de1b413.tar.xz wireguard-linux-22f9d2f4ee810e6442185ba7ecab37e24de1b413.zip |
net/mlx5: drop unnecessary list_empty
list_for_each_entry is able to handle an empty list.
The only effect of avoiding the loop is not initializing the
index variable.
Drop list_empty tests in cases where these variables are not
used.
Note that list_for_each_entry is defined in terms of list_first_entry,
which indicates that it should not be used on an empty list. But in
list_for_each_entry, the element obtained by list_first_entry is not
really accessed, only the address of its list_head field is compared
to the address of the list head, so the list_first_entry is safe.
The semantic patch that makes this change is as follows (with another
variant for the no brace case): (http://coccinelle.lip6.fr/)
<smpl>
@@
expression x,e;
iterator name list_for_each_entry;
statement S;
identifier i;
@@
-if (!(list_empty(x))) {
list_for_each_entry(i,x,...) S
- }
... when != i
? i = e
</smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Diffstat (limited to 'include/linux/jhash.h')
0 files changed, 0 insertions, 0 deletions